Review Request 128752: Mark invalid entries during practice and enable fixing in editor

[Dimitris Kardarakos]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128752/
-----------------------------------------------------------

(Updated Nov. 25, 2016, 8:31 a.m.)


Review request for KDE Edu.


Changes
-------

A new mode has been added (Fix Invalids Mode), found in Edit menu. In this mode only invalid entries are displayed. Moreover, creating new entries is disabled and Enter key does not automatically add a new entry. So, in this mode the user is supposed to just edit the invalid entries, toggle their activation status and exit.


Bugs: 170534
    http://bugs.kde.org/show_bug.cgi?id=170534


Repository: parley


Description
-------

During practicing, users may stumble upon an invalid entry
(typo, wrong match, etc). To enable users to timely handle these entries, in
practice main window, a new button (Invalid Entry) has been added. As soon as
users click on it, the current entry is set as invalid (deactivated), it is
excluded from the practice as well as from future practices. Session flow
moves on to the next entry.After the completion of the practice (or later)
users may navigate to the editor so as to fix invalid entries. These entries
can be identified by their negative (red) color. In Edit menu, a new action
to toggle activation status has been added. User may select a single or more
entries and toggle their activation status after fixing them. Valid entries'
color is set to non-negative again.


Diffs (updated)
-----

  src/collection/entryfilter.cpp a68c30d 
  src/collection/testentry.h a43eb6f 
  src/collection/testentry.cpp 3e152f1 
  src/collection/vocabularyfilter.h a309715 
  src/collection/vocabularyfilter.cpp 72902e3 
  src/collection/vocabularymodel.cpp 582701b 
  src/editor/editor.cpp c8f8f1c 
  src/editor/editorui.rc c9c928e 
  src/editor/vocabularyview.h 3730508 
  src/editor/vocabularyview.cpp 2760c06 
  src/parleyactions.h e87ce18 
  src/parleyactions.cpp ab8a518 
  src/practice/abstractfrontend.h f5f9552 
  src/practice/guifrontend.cpp 4ee6348 
  src/practice/practice_mainwindow.ui 00864ac 
  src/practice/practicestatemachine.h b67ba32 
  src/practice/practicestatemachine.cpp 994d9c1 
  src/settings/parley.kcfg e390683 

Diff: https://git.reviewboard.kde.org/r/128752/diff/


Testing
-------

Start practice
Mark 1st entry as invalid
Mark 2nd entry as invalid
Continue and finish
View summary (the invalids are marked as unanswered)
Open editor
Fix an invalid entry
Toggle activation status (so as to be included to future practices)


File Attachments (updated)
----------------

Short demo of the functionality
  https://git.reviewboard.kde.org/media/uploaded/files/2016/08/25/c011d3d0-8151-459e-98a5-39961fd812fc__parleyFixInvalids.webm
fix170534.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/11/25/430d2252-7f44-47da-96ad-0b1f3f5b3bda__fix170534.patch


Thanks,

Dimitris Kardarakos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20161125/4f1b065e/attachment.html>