<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128752/">https://git.reviewboard.kde.org/r/128752/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Dimitris Kardarakos.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2016, 8:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A new mode has been added (Fix Invalids Mode), found in Edit menu. In this mode only invalid entries are displayed. Moreover, creating new entries is disabled and Enter key does not automatically add a new entry. So, in this mode the user is supposed to just edit the invalid entries, toggle their activation status and exit.</p></pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=170534">170534</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">During practicing, users may stumble upon an invalid entry
(typo, wrong match, etc). To enable users to timely handle these entries, in
practice main window, a new button (Invalid Entry) has been added. As soon as
users click on it, the current entry is set as invalid (deactivated), it is
excluded from the practice as well as from future practices. Session flow
moves on to the next entry.After the completion of the practice (or later)
users may navigate to the editor so as to fix invalid entries. These entries
can be identified by their negative (red) color. In Edit menu, a new action
to toggle activation status has been added. User may select a single or more
entries and toggle their activation status after fixing them. Valid entries'
color is set to non-negative again.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Start practice
Mark 1st entry as invalid
Mark 2nd entry as invalid
Continue and finish
View summary (the invalids are marked as unanswered)
Open editor
Fix an invalid entry
Toggle activation status (so as to be included to future practices)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/collection/entryfilter.cpp <span style="color: grey">(a68c30d)</span></li>
<li>src/collection/testentry.h <span style="color: grey">(a43eb6f)</span></li>
<li>src/collection/testentry.cpp <span style="color: grey">(3e152f1)</span></li>
<li>src/collection/vocabularyfilter.h <span style="color: grey">(a309715)</span></li>
<li>src/collection/vocabularyfilter.cpp <span style="color: grey">(72902e3)</span></li>
<li>src/collection/vocabularymodel.cpp <span style="color: grey">(582701b)</span></li>
<li>src/editor/editor.cpp <span style="color: grey">(c8f8f1c)</span></li>
<li>src/editor/editorui.rc <span style="color: grey">(c9c928e)</span></li>
<li>src/editor/vocabularyview.h <span style="color: grey">(3730508)</span></li>
<li>src/editor/vocabularyview.cpp <span style="color: grey">(2760c06)</span></li>
<li>src/parleyactions.h <span style="color: grey">(e87ce18)</span></li>
<li>src/parleyactions.cpp <span style="color: grey">(ab8a518)</span></li>
<li>src/practice/abstractfrontend.h <span style="color: grey">(f5f9552)</span></li>
<li>src/practice/guifrontend.cpp <span style="color: grey">(4ee6348)</span></li>
<li>src/practice/practice_mainwindow.ui <span style="color: grey">(00864ac)</span></li>
<li>src/practice/practicestatemachine.h <span style="color: grey">(b67ba32)</span></li>
<li>src/practice/practicestatemachine.cpp <span style="color: grey">(994d9c1)</span></li>
<li>src/settings/parley.kcfg <span style="color: grey">(e390683)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128752/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/25/c011d3d0-8151-459e-98a5-39961fd812fc__parleyFixInvalids.webm">Short demo of the functionality</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/11/25/430d2252-7f44-47da-96ad-0b1f3f5b3bda__fix170534.patch">fix170534.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>