Review Request 128536: [parley] Change version string to script generated KDE Applications Version

Hartmut Riesenbeck hartmut.riesenbeck at gmx.de
Sun Nov 6 14:29:37 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128536/
-----------------------------------------------------------

(Updated Nov. 6, 2016, 2:29 nachm.)


Review request for KDE Edu.


Changes
-------

Applied suggestions from Burkhard Lück. Version string format is now "x.y.z (Applications xx.yy.zz)".


Repository: parley


Description
-------

Since I noticed that parleys version string didn't changed for quite a long time, I make the suggestion to set it to the KDE Applications version like in many other KDE applications.

For my implementation I used the method descrbied here:
https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning

This has the advantage that the version string is automaticly set to the current KDE Applictions Version by script. Wich makes it much easier to associate bugs from the bug tracking system the the appropriate version.

The patch shows both - the program version and the KDE Applications Version. For the vocabulary document file only the program version is used.


Diffs (updated)
-----

  CMakeLists.txt dbc7a3f72e02d77d9e76338fe829852760affce4 
  config-parley.h.cmake fba6bdb49c652cd15282a9cbafdf044202f2976b 
  src/main.cpp 4a48b3f91db56cc8734ddd158673b5bce823b563 

Diff: https://git.reviewboard.kde.org/r/128536/diff/


Testing
-------


Thanks,

Hartmut Riesenbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20161106/34cc5d49/attachment.html>


More information about the kde-edu mailing list