Review Request 128536: [parley] Change version string to script generated KDE Applications Version

[Burkhard Lück]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128536/#review100615
-----------------------------------------------------------




src/main.cpp (lines 51 - 53)
<https://git.reviewboard.kde.org/r/128536/#comment67538>

    please use something like ki18nc("%1 parley version, %2 applications version","%1 (KDE Applications %2)",PARLEY_VERSION_STRING, KDE_APPLICATIONS_VERSION )
    
    Btw in docbooks we use <releaseinfo>xx.yy (Applications xx.yy)</releaseinfo> without KDE


- Burkhard Lück


On Nov. 5, 2016, 8:14 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128536/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2016, 8:14 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Since I noticed that parleys version string didn't changed for quite a long time, I make the suggestion to set it to the KDE Applications version like in many other KDE applications.
> 
> For my implementation I used the method descrbied here:
> https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning
> 
> This has the advantage that the version string is automaticly set to the current KDE Applictions Version by script. Wich makes it much easier to associate bugs from the bug tracking system the the appropriate version.
> 
> The patch shows both - the program version and the KDE Applications Version. For the vocabulary document file only the program version is used.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt dbc7a3f72e02d77d9e76338fe829852760affce4 
>   config-parley.h.cmake fba6bdb49c652cd15282a9cbafdf044202f2976b 
>   src/main.cpp 4a48b3f91db56cc8734ddd158673b5bce823b563 
> 
> Diff: https://git.reviewboard.kde.org/r/128536/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20161105/9f8a3dd2/attachment.html>