Review Request 128926: More robust version check for Sage

[Antonio Rojas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128926/#review100461
-----------------------------------------------------------



Ping? 7.4 release is out now, so the Sage backend is now officially broken.

- Antonio Rojas


On Sept. 19, 2016, 8:30 p.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128926/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Edu and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Version check for Sage is once again broken with the latest version. Instead of relying on parsing the sage banner, which is likely to break with changes in Sage output format, use the dedicated 'sage -v' command.
> 
> 
> Diffs
> -----
> 
>   src/backends/sage/sagesession.cpp bd2c3dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128926/diff/
> 
> 
> Testing
> -------
> 
> Correct version is detected again according to the console output. Note that the backend is still broken with latest Sage, but that's a separate issue.
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20161101/c4b72b44/attachment.html>