Review Request 127305: Parley: Re-design multiple choice practice

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127305/#review93964
-----------------------------------------------------------


Ship it!




Thanks for your contribution. Do you have commit rights or shall I commit it for you?
This change should go into the Applications/16.04 branch.

- Andreas Cord-Landwehr


On März 14, 2016, 2:37 vorm., Julian Helfferich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127305/
> -----------------------------------------------------------
> 
> (Updated März 14, 2016, 2:37 vorm.)
> 
> 
> Review request for KDE Edu and KDE Usability.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> I have redesigned the Multiple Choice Practice Widget. Instead of QRadioButtons, the new design uses QPushButtons and tweaks their appearance using Qt Style Sheets making sure that the design works with all themes available on Get Hot New Stuff. The results are displayed in the screenshots attached:
> 
> New design:
> In screenshot 1, entry 2 has keyboard focus while the mouse is hovering over entry 5. This uses the Gray theme.
> In screenshot 2, the wrong entry 3 was selected. Additionally, the correct entry 2 is highlighted. Here, the Darkness theme is used.
> In screenshot 3, the correct entry 3 was selected. Here, the Bees theme is used.
> 
> Old design:
> Screenshots 4-6 correspond to screenshots 1-3, but using the old design for comparison.
> 
> I think, the new approach has some advantages over the old QRadioButton approach.
> 
> * Labels 1-5 indicate that entries can be selected by using this numbers as shortcuts.
> * Borders around the words instead of underlining the word makes it clearer which entry is selected.
> * Black text on light red or light green background is more legible than red/green text.
> 
> I have put much thought into this change and while I think the new approach is an improvement, I have also come to appreciate the QRadioButton approach. I am looking forward to hear your thoughts.
> 
> 
> Diffs
> -----
> 
>   src/practice/multiplechoicemodewidget.h 0d0b43c 
>   src/practice/multiplechoicemodewidget.cpp 74b3279 
> 
> Diff: https://git.reviewboard.kde.org/r/127305/diff/
> 
> 
> Testing
> -------
> 
> Practiced words:
> 
> * Selected correct entry
> * Selceted wrong entry
> * Pressed "Continue"
> * Pressed "Answer later"
> 
> I tested the new design with all backgrounds available with Get Hot New Stuff.
> 
> 
> File Attachments
> ----------------
> 
> New design: Entry selected, theme Gray
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/07/1209538e-5838-42cf-9a07-4b1df976f4ee__snapshot1.png
> New design: Wrong answer, theme Darkness
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/07/63818cda-70a3-4592-865a-6ff59ddef7a8__snapshot2.png
> New design: Correct answer, theme Bee
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/14/dbfc2cae-e3bc-4ab8-91c1-b628eca8c6c5__snapshot3.png
> Old design: Entry selected, theme Gray
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/14/aa431bf6-7e6f-494d-84c8-e6b610222bca__snapshot4.png
> Old design: Wrong answer, theme Darkness
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/14/32eeb97b-5730-4fd4-bdd5-1b96168398ae__snapshot5.png
> Old design: Correct answer, theme Bees
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/14/eee260f4-4c7d-42d6-a4bf-a62dcc0707b7__snapshot6.png
> 
> 
> Thanks,
> 
> Julian Helfferich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160325/05258482/attachment.html>