Review Request 127441: Fix never ending event loop when quitting app and segmentation faults

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127441/#review93962
-----------------------------------------------------------


Ship it!




Nice work, please commit to the Applications/16.04 branch and then merge to master.

- Andreas Cord-Landwehr


On März 22, 2016, 8:19 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127441/
> -----------------------------------------------------------
> 
> (Updated März 22, 2016, 8:19 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> When the app is quited app.exec() doesn't return. The process stays in
> sleeping state. Removed app.setQuitOnLastWindowClosed(false) because
> the quit() or exec() method of the application were not invoked
> somewhere else in the application.
> 
> After this the app ends in the correct way. But after quit is invoked,
> there are sporadic segmentation faults and the following message was
> shown on stderr:
>     QCoreApplication::postEvent: Unexpected null receiver
> This was fixed by removing zero pointer access in destuctor of
> ParleyDocument.
> 
> Added missing this pointer on KEduVocDocument allocation.
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 2e87baa93f81349a187d620be2468f8a1bb4aca1 
>   src/parleydocument.cpp cf4c81c3f8f35a99389d61a75d934cff3170b960 
>   src/parleymainwindow.cpp d6f86debd32c1e77bbcca86a160906674960dce9 
> 
> Diff: https://git.reviewboard.kde.org/r/127441/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160325/068e27d6/attachment.html>