Review Request 127354: improve drawing precision for circles

[Maurizio Paolini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127354/
-----------------------------------------------------------

(Updated March 13, 2016, 1:09 p.m.)


Review request for KDE Edu, David Narváez and Rex Dieter.


Summary (updated)
-----------------

improve drawing precision for circles


Bugs: https://bugs.kde.org/show_bug.cgi?id=359805).
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=359805).


Repository: kig


Description
-------

QRect object in qt uses integers.  This causes annoying loss of drawing precision when drawing circles (https://bugs.kde.org/show_bug.cgi?id=359805).  Using the QRectF object seems more appropriate.


Diffs
-----

  misc/kigpainter.h e36c153 
  misc/kigpainter.cpp e547bf2 
  misc/screeninfo.h b7f94c4 
  misc/screeninfo.cc 8fdf115 

Diff: https://git.reviewboard.kde.org/r/127354/diff/


Testing
-------

This is a minimal patch to allow using QRectF when drawing circles.  Perhaps using QRect
(and QPoint) could be dropped completely in favour of QRectF and QPointF.


Thanks,

Maurizio Paolini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160313/b18cf0bb/attachment.html>