Review Request 127354: improve dwawing precision for circles

Maurizio Paolini paolini at dmf.unicatt.it
Sat Mar 12 10:10:38 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127354/
-----------------------------------------------------------

Review request for KDE Edu, David Narváez and Rex Dieter.


Bugs: https://bugs.kde.org/show_bug.cgi?id=359805).
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=359805).


Repository: kig


Description
-------

QRect object in qt uses integers.  This causes annoying loss of drawing precision when drawing circles (https://bugs.kde.org/show_bug.cgi?id=359805).  Using the QRectF object seems more appropriate.


Diffs
-----

  misc/kigpainter.h e36c153 
  misc/kigpainter.cpp e547bf2 
  misc/screeninfo.h b7f94c4 
  misc/screeninfo.cc 8fdf115 

Diff: https://git.reviewboard.kde.org/r/127354/diff/


Testing
-------

This is a minimal patch to allow using QRectF when drawing circles.  Perhaps using QRect
(and QPoint) could be dropped completely in favour of QRectF and QPointF.


Thanks,

Maurizio Paolini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160312/4f65f8ce/attachment.html>


More information about the kde-edu mailing list