Review Request 127305: Parley: Re-design multiple choice practice

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127305/#review93283
-----------------------------------------------------------



Hi, I pretty much like your change (though not tested it yet). Just found a small coding nitpicks.
Also, I added the usability group as reviewer to get some more opinions about the overall change.


src/practice/multiplechoicemodewidget.cpp (line 23)
<https://git.reviewboard.kde.org/r/127305/#comment63602>

    in new code we avoid using Qt modules
    since you already change this line just use "#include <QPushButton>"



src/practice/multiplechoicemodewidget.cpp (line 104)
<https://git.reviewboard.kde.org/r/127305/#comment63603>

    coding style: push_button -> pushButton (camelcase)



src/practice/multiplechoicemodewidget.cpp (line 123)
<https://git.reviewboard.kde.org/r/127305/#comment63604>

    coding style (the file unfortunately not really sticks to a common coding style, but let's try to make all new code compatible with the Qt coding style + KF5 changes https://techbase.kde.org/Policies/Frameworks_Coding_Style):
    remove space after "("



src/practice/multiplechoicemodewidget.cpp (line 194)
<https://git.reviewboard.kde.org/r/127305/#comment63608>

    for the sake of making the code easier to understand, I would make this variable and the following two "const"



src/practice/multiplechoicemodewidget.cpp (line 196)
<https://git.reviewboard.kde.org/r/127305/#comment63605>

    QString("#90") -> QStringLiteral("#90")



src/practice/multiplechoicemodewidget.cpp (line 199)
<https://git.reviewboard.kde.org/r/127305/#comment63606>

    also QStringLiteral



src/practice/multiplechoicemodewidget.cpp (line 269)
<https://git.reviewboard.kde.org/r/127305/#comment63611>

    same as above: I would make the layout variables const



src/practice/multiplechoicemodewidget.cpp (line 272)
<https://git.reviewboard.kde.org/r/127305/#comment63607>

    QStringLiteral



src/practice/multiplechoicemodewidget.cpp (line 296)
<https://git.reviewboard.kde.org/r/127305/#comment63609>

    coding style: spaces



src/practice/multiplechoicemodewidget.cpp (line 298)
<https://git.reviewboard.kde.org/r/127305/#comment63610>

    coding style: spaces


- Andreas Cord-Landwehr


On März 7, 2016, 4:02 nachm., Julian Helfferich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127305/
> -----------------------------------------------------------
> 
> (Updated März 7, 2016, 4:02 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> I have redesigned the Multiple Choice Practice Widget. Instead of QRadioButtons, the new design uses QPushButtons and tweaks their appearance using Qt Style Sheets making sure that the design works with all themes available on Get Hot New Stuff. The results are displayed in the two screenshots attached:
> 
> In screenshot 1, entry 2 has keyboard focus while the mouse is hovering over entry 5. This uses the Gray theme.
> In screenshot 2, the wrong entry 3 was selected. Additionally, the correct entry 2 is highlighted. Here, the Darkness theme is used.
> 
> I think, the new approach has some advantages over the old QRadioButton approach.
> 
> * Labels 1-5 indicate that entries can be selected by using this numbers as shortcuts.
> * Borders around the words instead of underlining the word makes it clearer which entry is selected.
> * Black text on light red or light green background is more legible than red/green text.
> 
> I have put much thought into this change and while I think the new approach is an improvement, I have also come to appreciate the QRadioButton approach. I am looking forward to hear your thoughts.
> 
> 
> Diffs
> -----
> 
>   src/practice/multiplechoicemodewidget.h 0d0b43c 
>   src/practice/multiplechoicemodewidget.cpp 74b3279 
> 
> Diff: https://git.reviewboard.kde.org/r/127305/diff/
> 
> 
> Testing
> -------
> 
> Practiced words:
> 
> * Selected correct entry
> * Selceted wrong entry
> * Pressed "Continue"
> * Pressed "Answer later"
> 
> I tested the new design with all backgrounds available with Get Hot New Stuff.
> 
> 
> File Attachments
> ----------------
> 
> Entry selected
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/07/1209538e-5838-42cf-9a07-4b1df976f4ee__snapshot1.png
> Wrong answer
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/07/63818cda-70a3-4592-865a-6ff59ddef7a8__snapshot2.png
> 
> 
> Thanks,
> 
> Julian Helfferich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160308/d5760e69/attachment-0001.html>