Review Request 127305: Parley: Re-design multiple choice practice

Julian Helfferich julian.helfferich at
Mon Mar 7 16:02:12 UTC 2016

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Edu.

Repository: parley


I have redesigned the Multiple Choice Practice Widget. Instead of QRadioButtons, the new design uses QPushButtons and tweaks their appearance using Qt Style Sheets making sure that the design works with all themes available on Get Hot New Stuff. The results are displayed in the two screenshots attached:

In screenshot 1, entry 2 has keyboard focus while the mouse is hovering over entry 5. This uses the Gray theme.
In screenshot 2, the wrong entry 3 was selected. Additionally, the correct entry 2 is highlighted. Here, the Darkness theme is used.

I think, the new approach has some advantages over the old QRadioButton approach.

* Labels 1-5 indicate that entries can be selected by using this numbers as shortcuts.
* Borders around the words instead of underlining the word makes it clearer which entry is selected.
* Black text on light red or light green background is more legible than red/green text.

I have put much thought into this change and while I think the new approach is an improvement, I have also come to appreciate the QRadioButton approach. I am looking forward to hear your thoughts.


  src/practice/multiplechoicemodewidget.h 0d0b43c 
  src/practice/multiplechoicemodewidget.cpp 74b3279 



Practiced words:

* Selected correct entry
* Selceted wrong entry
* Pressed "Continue"
* Pressed "Answer later"

I tested the new design with all backgrounds available with Get Hot New Stuff.

File Attachments

Entry selected
Wrong answer


Julian Helfferich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-edu mailing list