Review Request 127155: Fix Bug 350887: Practise conjugations doesn't work

Hartmut Riesenbeck hartmut.riesenbeck at
Tue Mar 1 19:15:29 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated March 1, 2016, 8:15 p.m.)


This change has been marked as submitted.

Review request for KDE Edu.


Submitted with commit a6c0dbdbf6fdb0190e4dec881154fd64d112a705 by Andreas Cord-Landwehr on behalf of Hartmut Riesenbeck to branch master.

Bugs: 350887

Repository: parley


To make practice conjugations work two bugs had to be fixed:

The first bug was caused by uninitialized member variable m_toTranslation
in EntryFilter constructor. This caused that DocumentSettings could
not be loaded and EntryFilter::m_tenses was empty (later in 
EntryFilter::cleanupInvalid method). Changed constructor to init 
m_toTranslation from Prefs::learningLanguage() and m_fromTranslation 
from Prefs::knownLanguage(). The second was not necessary to load the
document settings, but was inserted for the sake of order.

The member m_tenses is used in EntryFilter::cleanupInvalid method to
remove entries which don't have any of the tenses which are configured
for practice. Now that document settings was not loaded propperly before,
m_tenses is empty. Because m_tenses was empty, all entries were removed
and the error dialog was shown.

After this was fixed, it came out that the conjugation prcatice widget
didn't dispaly the verbs to_translation and from_translation. This was
causd by an incomplete initialisation of TestEntry objects in
EntryFilter::conjugationTestEntries method. This was fixed by init the
To- and From-Language of each new test enty from m_toTranslation and
m_fromTranslation of EntryFilter.


  src/collection/entryfilter.cpp 5264226f9f9cf69d6c77fefd498ffbbc744b56e7 




Hartmut Riesenbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-edu mailing list