Review Request 128212: libkeduvocdocument: Non const references methods in KEduVocTranslation are set deprecated

Hartmut Riesenbeck hartmut.riesenbeck at gmx.de
Thu Jun 16 20:07:20 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128212/
-----------------------------------------------------------

(Updated Juni 16, 2016, 8:07 nachm.)


Review request for KDE Edu.


Changes
-------

Applied changes suggested by Jeremy Whiting.


Repository: libkeduvocdocument


Description
-------

Two methods which returns non const refereces to private member values
of KEduVocTranslation have been set as deprecated. Alternative
getter/setter methods were added. The usage of the deprecated methods
in the library were refactored to new methods.


Diffs (updated)
-----

  keduvocdocument/keduvockvtml2writer.cpp 682095503680ddf4fd2f1dfe3de8e94fc28fc69d 
  keduvocdocument/keduvoctranslation.h 2b72d7a516352ed6f1418d0b9d7a0ac56f511e42 
  keduvocdocument/keduvoctranslation.cpp c098060fe98679edd5f45cd451657d378d08cdd9 
  keduvocdocument/readerwriters/keduvockvtml2reader.cpp 0bcb4bde0b3455f171002294aad4488abb175543 
  keduvocdocument/readerwriters/keduvockvtmlreader.cpp 063ac7e2eba447334ea7ead7ba4ed17b3f361de8 

Diff: https://git.reviewboard.kde.org/r/128212/diff/


Testing
-------

Unit tests passed.


Thanks,

Hartmut Riesenbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160616/1005803f/attachment.html>


More information about the kde-edu mailing list