Review Request 128212: libkeduvocdocument: Non const references methods in KEduVocTranslation are set deprecated

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128212/#review96606
-----------------------------------------------------------



Fix the above then ship it.


keduvocdocument/keduvoctranslation.h (line 214)
<https://git.reviewboard.kde.org/r/128212/#comment65278>

    I wouldn't put "Bad, only compatibility." Please change to "This method is deprecated, please use @see foo"



keduvocdocument/keduvoctranslation.h (line 227)
<https://git.reviewboard.kde.org/r/128212/#comment65277>

    probably want to name the variable choices like the @param comment says :)


- Jeremy Whiting


On June 16, 2016, 8:52 a.m., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128212/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 8:52 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> Two methods which returns non const refereces to private member values
> of KEduVocTranslation have been set as deprecated. Alternative
> getter/setter methods were added. The usage of the deprecated methods
> in the library were refactored to new methods.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/keduvockvtml2writer.cpp 682095503680ddf4fd2f1dfe3de8e94fc28fc69d 
>   keduvocdocument/keduvoctranslation.h 2b72d7a516352ed6f1418d0b9d7a0ac56f511e42 
>   keduvocdocument/keduvoctranslation.cpp c098060fe98679edd5f45cd451657d378d08cdd9 
>   keduvocdocument/readerwriters/keduvockvtml2reader.cpp 0bcb4bde0b3455f171002294aad4488abb175543 
>   keduvocdocument/readerwriters/keduvockvtmlreader.cpp 063ac7e2eba447334ea7ead7ba4ed17b3f361de8 
> 
> Diff: https://git.reviewboard.kde.org/r/128212/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160616/d68eae64/attachment.html>