Review Request 128298: KCrash initialize problem

[Albert Astals Cid]

> On June 28, 2016, 2:45 p.m., Jeremy Whiting wrote:
> > KCrash::initialize is right here: https://api.kde.org/frameworks/kcrash/html/namespaceKCrash.html#af3cbae2933366133fd4e666568521232 Maybe you are missing frameworks dev packages required to build khangman or something?
> 
> Sayan Biswas wrote:
>     I checked again with my system, it looks like the KF5 packages which were installed from the Ubuntu package manager didn't have the latest KCrash(I cross checked the header files of the latest documentation and the header file in my system). I shouldn't have blindly believed the package manager should have build the packages from source.
>     
>     Thanks a lot! Do I need to drop a mail to the ubuntu devel to update it?
> 
> Jeremy Whiting wrote:
>     Well the documentation there says it's since KF5 5.15. What version of kcrash package do you have from ubuntu? http://packages.ubuntu.com/xenial/libkf5crash-dev shows xenial has 5.18, wily has 5.15, are you running one of those or an older version of Ubuntu?
> 
> Sayan Biswas wrote:
>     I have uninstalled KF5 completely but I guess I had version 3.5 or higher, definetly not 5+. I changed the method name as the diff and checked and it was working perfectly but I think since version 5+ initialize() is recommended in main(). I use Ubuntu 15.04 and I used the command 'apt-get install KF5*' to install the packages.
> 
> Jeremy Whiting wrote:
>     There's no such thing as frameworks 3.5. You need to upgrade to a newer version of ububtu if you want to build khangman master branch.
> 
> Sayan Biswas wrote:
>     I meant to say kdelib 3.5! Anyways, I think I have to build it from source. Last time I tried to upgrade ubuntu, it lead to really devastating result. Anyways thanks for the help.

I've fixed the khangman CMakeLists.txt adding the minimum required KF5 version to be 5.15. I'll also close this request since it's wrong.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128298/#review96922
-----------------------------------------------------------


On June 28, 2016, 7:33 a.m., Sayan Biswas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128298/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 7:33 a.m.)
> 
> 
> Review request for KDE Edu, Rahul Chowdhury and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> KCrash not working for initialize
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 73b5615 
> 
> Diff: https://git.reviewboard.kde.org/r/128298/diff/
> 
> 
> Testing
> -------
> 
> For more Details of the problem, you can check this link -> http://pastebin.com/SxMreGYt
> 
> It is not tested in all the environments but I haven't found any initialize method in the KCrash documentation.
> 
> 
> Thanks,
> 
> Sayan Biswas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160703/c696f085/attachment.html>