<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128298/">https://git.reviewboard.kde.org/r/128298/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 28th, 2016, 2:45 p.m. UTC, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KCrash::initialize is right here: https://api.kde.org/frameworks/kcrash/html/namespaceKCrash.html#af3cbae2933366133fd4e666568521232 Maybe you are missing frameworks dev packages required to build khangman or something?</p></pre>
</blockquote>
<p>On June 29th, 2016, 6:16 a.m. UTC, <b>Sayan Biswas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I checked again with my system, it looks like the KF5 packages which were installed from the Ubuntu package manager didn't have the latest KCrash(I cross checked the header files of the latest documentation and the header file in my system). I shouldn't have blindly believed the package manager should have build the packages from source.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks a lot! Do I need to drop a mail to the ubuntu devel to update it?</p></pre>
</blockquote>
<p>On June 29th, 2016, 2:18 p.m. UTC, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well the documentation there says it's since KF5 5.15. What version of kcrash package do you have from ubuntu? http://packages.ubuntu.com/xenial/libkf5crash-dev shows xenial has 5.18, wily has 5.15, are you running one of those or an older version of Ubuntu?</p></pre>
</blockquote>
<p>On July 1st, 2016, 5:50 a.m. UTC, <b>Sayan Biswas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have uninstalled KF5 completely but I guess I had version 3.5 or higher, definetly not 5+. I changed the method name as the diff and checked and it was working perfectly but I think since version 5+ initialize() is recommended in main(). I use Ubuntu 15.04 and I used the command 'apt-get install KF5*' to install the packages.</p></pre>
</blockquote>
<p>On July 1st, 2016, 5:10 p.m. UTC, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There's no such thing as frameworks 3.5. You need to upgrade to a newer version of ububtu if you want to build khangman master branch.</p></pre>
</blockquote>
<p>On July 1st, 2016, 5:16 p.m. UTC, <b>Sayan Biswas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I meant to say kdelib 3.5! Anyways, I think I have to build it from source. Last time I tried to upgrade ubuntu, it lead to really devastating result. Anyways thanks for the help.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've fixed the khangman CMakeLists.txt adding the minimum required KF5 version to be 5.15. I'll also close this request since it's wrong.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On June 28th, 2016, 7:33 a.m. UTC, Sayan Biswas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Rahul Chowdhury and Jeremy Whiting.</div>
<div>By Sayan Biswas.</div>
<p style="color: grey;"><i>Updated June 28, 2016, 7:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khangman
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KCrash not working for initialize</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For more Details of the problem, you can check this link -> http://pastebin.com/SxMreGYt</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is not tested in all the environments but I haven't found any initialize method in the KCrash documentation.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/main.cpp <span style="color: grey">(73b5615)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128298/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>