Review Request 127156: Call off EntryFilter::expireEntries has no effect

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127156/#review92866
-----------------------------------------------------------




src/collection/entryfilter.cpp (line 115)
<https://git.reviewboard.kde.org/r/127156/#comment63335>

    For me it would look more logical to just exchange the order of expireEntries(pass) and collectEntries(pass). Since otherwise, the behavior of collectEntries changes and I am not sure that its method name reflects the new behavior.


- Andreas Cord-Landwehr


On Feb. 23, 2016, 9:08 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127156/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 9:08 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> In EntryFilter::expireEntries() the set 
> EntryFilter::m_entries is checked for entries 
> which hasn't practiced for a defined amount of 
> time and decreases the grad if this was expired.
> 
> But at time of calling expireEntries() this could 
> not work because m_entries was not intialisised 
> and empty. The method call was moved to a place 
> where m_entries is filled and cleaned of invalid 
> entries.
> 
> 
> Diffs
> -----
> 
>   src/collection/entryfilter.cpp 5264226 
> 
> Diff: https://git.reviewboard.kde.org/r/127156/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160228/94ef74ec/attachment.html>