Review Request 127156: Call off EntryFilter::expireEntries has no effect

Hartmut Riesenbeck hartmut.riesenbeck at gmx.de
Tue Feb 23 21:08:25 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127156/
-----------------------------------------------------------

Review request for KDE Edu.


Repository: parley


Description (updated)
-------

In EntryFilter::expireEntries() the set 
EntryFilter::m_entries is checked for entries 
which hasn't practiced for a defined amount of 
time and decreases the grad if this was expired.

But at time of calling expireEntries() this could 
not work because m_entries was not intialisised 
and empty. The method call was moved to a place 
where m_entries is filled and cleaned of invalid 
entries.


Diffs (updated)
-----

  src/collection/entryfilter.cpp 5264226 

Diff: https://git.reviewboard.kde.org/r/127156/diff/


Testing
-------


Thanks,

Hartmut Riesenbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160223/947b5095/attachment.html>


More information about the kde-edu mailing list