Review Request 127063: Fix Bug 356239 and facilitate proper grammar downloading

[Dimitris Kardarakos]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127063/
-----------------------------------------------------------

(Updated Feb. 15, 2016, 1:56 p.m.)


Review request for KDE Edu.


Changes
-------

Use const iterator and provide API comments for the key-value map introduced


Bugs: 356239
    http://bugs.kde.org/show_bug.cgi?id=356239


Repository: parley


Description
-------

Fix Bug 356239 and facilitate proper grammar downloading


Diffs (updated)
-----

  src/collection/collection.cpp 23a6d4e 
  src/parleydocument.cpp 65bc0b6 
  src/settings/documentproperties.h a9d69cc 
  src/settings/documentproperties.cpp 7a7cc45 
  src/settings/languagepropertiespage.cpp bea82ec 

Diff: https://git.reviewboard.kde.org/r/127063/diff/


Testing
-------

After porting to frameworks, only languages from the currently installed language packages can be selected when creating a new collection. Moreover, grammar fetching does not work in some cases even if the grammar file exists in http://edu.kde.org/parley/locale/.

Instead of using QLocale().uiLanguages() in order to create the combobox of to-be-selected languages, a key map has been created with key = language-country, value = locale. Now, user is presented with a list of Language (Country) entries. After selecting, the locale (value of the key map) is set to the data part of the combobox. So, the looping in uiLanguages() in DocumentProperties::acceptLanguageConfiguration can be avoided.

uiLanguages() returns an ordered list of locale names like "en-Latn-US", "en-US", "en". E.g., in case of american english, en-US is set. Trying to fetch the grammar from http://edu.kde.org/parley/locale/, although en.kvtml exists, we cannot get the grammar. With this fix, locale info is stored as a string of the form "language_country" (using QLocal name() function). When trying to fetch grammar, only the first part (language) is used. Thus, de.kvtml, en.kvtml, es.kvtml, fr.kvtml can now be properly downloaded.


File Attachments (updated)
----------------

fix356239v2.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/15/5a6145e5-6445-47eb-936c-80999de51291__fix356239v2.patch


Thanks,

Dimitris Kardarakos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160215/dcb94f0c/attachment.html>