Review Request 127063: Fix Bug 356239 and facilitate proper grammar downloading

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127063/#review92392
-----------------------------------------------------------



LGTM, only found two minors. Thanks for your work!
However, I would like to see a unit test for the fetchGrammar method, since fetching data from a web storage is something fragile IMO and we should be notified by a broken test when that happens again.
What do you think?


src/settings/documentproperties.h (line 39)
<https://git.reviewboard.kde.org/r/127063/#comment63009>

    can you add a small API documentation about the meaning of the two strings in the map?



src/settings/documentproperties.cpp (line 63)
<https://git.reviewboard.kde.org/r/127063/#comment63010>

    performance-wise, better use a const iterator over the map than iterating over all keys


- Andreas Cord-Landwehr


On Feb. 13, 2016, 2:58 nachm., Dimitris Kardarakos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127063/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 2:58 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 356239
>     http://bugs.kde.org/show_bug.cgi?id=356239
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Fix Bug 356239 and facilitate proper grammar downloading
> 
> 
> Diffs
> -----
> 
>   src/collection/collection.cpp 23a6d4e 
>   src/parleydocument.cpp 65bc0b6 
>   src/settings/documentproperties.h a9d69cc 
>   src/settings/documentproperties.cpp 7a7cc45 
>   src/settings/languagepropertiespage.cpp bea82ec 
> 
> Diff: https://git.reviewboard.kde.org/r/127063/diff/
> 
> 
> Testing
> -------
> 
> After porting to frameworks, only languages from the currently installed language packages can be selected when creating a new collection. Moreover, grammar fetching does not work in some cases even if the grammar file exists in http://edu.kde.org/parley/locale/.
> 
> Instead of using QLocale().uiLanguages() in order to create the combobox of to-be-selected languages, a key map has been created with key = language-country, value = locale. Now, user is presented with a list of Language (Country) entries. After selecting, the locale (value of the key map) is set to the data part of the combobox. So, the looping in uiLanguages() in DocumentProperties::acceptLanguageConfiguration can be avoided.
> 
> uiLanguages() returns an ordered list of locale names like "en-Latn-US", "en-US", "en". E.g., in case of american english, en-US is set. Trying to fetch the grammar from http://edu.kde.org/parley/locale/, although en.kvtml exists, we cannot get the grammar. With this fix, locale info is stored as a string of the form "language_country" (using QLocal name() function). When trying to fetch grammar, only the first part (language) is used. Thus, de.kvtml, en.kvtml, es.kvtml, fr.kvtml can now be properly downloaded.
> 
> 
> Thanks,
> 
> Dimitris Kardarakos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160215/f3b7403a/attachment.html>