Review Request 127661: Phabricator T1661: Re-positioning axis label.

Garvit Khatri garvitdelhi at gmail.com
Sat Apr 16 11:14:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127661/#review94645
-----------------------------------------------------------




src/backend/worksheet/plots/cartesian/Axis.cpp (line 2002)
<https://git.reviewboard.kde.org/r/127661/#comment64328>

    hey, this change will crash labplot for the older files. And I guess we would like to have some backward compatibility. it will be good if you check if titleOffset is present or not and load the file accordingly.


- Garvit Khatri


On April 16, 2016, 10:34 a.m., Anu Mittal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127661/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 10:34 a.m.)
> 
> 
> Review request for KDE Edu, Alexander Semke and Garvit Khatri.
> 
> 
> Repository: labplot
> 
> 
> Description
> -------
> 
> These are the changes I have made till now, have implemented the idea of changing offset to offsetX and offsetY.But according to the discussion which I had with asemke on phabricator task I will now remove the limits of offset and rename it to 'x' and 'y' and then finally make it dragable with the click of mouse.
> 
> 
> Diffs
> -----
> 
>   src/backend/worksheet/plots/cartesian/Axis.h 03932c6 
>   src/backend/worksheet/plots/cartesian/Axis.cpp b56d9c5 
>   src/backend/worksheet/plots/cartesian/AxisPrivate.h cc0a659 
>   src/backend/worksheet/plots/cartesian/CartesianPlot.cpp bdfae24 
>   src/kdefrontend/ui/labelwidget.ui 06b058f 
>   src/kdefrontend/widgets/LabelWidget.h 72bcf09 
>   src/kdefrontend/widgets/LabelWidget.cpp 4ac385c 
> 
> Diff: https://git.reviewboard.kde.org/r/127661/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anu Mittal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160416/9f5fe4cf/attachment.html>


More information about the kde-edu mailing list