<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127661/">https://git.reviewboard.kde.org/r/127661/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127661/diff/1/?file=456174#file456174line2002" style="color: black; font-weight: bold; text-decoration: underline;">src/backend/worksheet/plots/cartesian/Axis.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1990</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="n">str</span> <span class="o">=</span> <span class="n">attribs</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="s">"titleOffset"</span><span class="p">).</span><span class="n">toString</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2002</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="n">str</span> <span class="o">=</span> <span class="n">attribs</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="s">"titleOffset<span class="hl">X</span>"</span><span class="p">).</span><span class="n">toString</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">hey, this change will crash labplot for the older files. And I guess we would like to have some backward compatibility. it will be good if you check if titleOffset is present or not and load the file accordingly.</p></pre>
</div>
</div>
<br />
<p>- Garvit Khatri</p>
<br />
<p>On April 16th, 2016, 10:34 a.m. UTC, Anu Mittal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Alexander Semke and Garvit Khatri.</div>
<div>By Anu Mittal.</div>
<p style="color: grey;"><i>Updated April 16, 2016, 10:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
labplot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These are the changes I have made till now, have implemented the idea of changing offset to offsetX and offsetY.But according to the discussion which I had with asemke on phabricator task I will now remove the limits of offset and rename it to 'x' and 'y' and then finally make it dragable with the click of mouse.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backend/worksheet/plots/cartesian/Axis.h <span style="color: grey">(03932c6)</span></li>
<li>src/backend/worksheet/plots/cartesian/Axis.cpp <span style="color: grey">(b56d9c5)</span></li>
<li>src/backend/worksheet/plots/cartesian/AxisPrivate.h <span style="color: grey">(cc0a659)</span></li>
<li>src/backend/worksheet/plots/cartesian/CartesianPlot.cpp <span style="color: grey">(bdfae24)</span></li>
<li>src/kdefrontend/ui/labelwidget.ui <span style="color: grey">(06b058f)</span></li>
<li>src/kdefrontend/widgets/LabelWidget.h <span style="color: grey">(72bcf09)</span></li>
<li>src/kdefrontend/widgets/LabelWidget.cpp <span style="color: grey">(4ac385c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127661/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>