Review Request 125206: Port of KIO::NetAccess

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125206/#review85282
-----------------------------------------------------------



src/editor.cpp (line 175)
<https://git.reviewboard.kde.org/r/125206/#comment58941>

    This QFile file(fileString); needs to change to QFile file(job->url().toLocalFile());



src/editor.cpp (line 191)
<https://git.reviewboard.kde.org/r/125206/#comment58942>

    Just use QFile::remove, not QTemporaryFile::remove, since the file isn't a QTemporaryFile, it's just a file downloaded by KIO::storedGet.



src/editor.cpp (line 255)
<https://git.reviewboard.kde.org/r/125206/#comment58943>

    Remove the old code, don't just comment it out please.


Looks like aleix beat me to it, anyway, I found the same problems :)

- Jeremy Whiting


On Sept. 12, 2015, 2:28 p.m., Sayan Biswas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125206/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 2:28 p.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: kturtle
> 
> 
> Description
> -------
> 
> Port of KIO::NetAccess
> 
> 
> Diffs
> -----
> 
>   src/editor.cpp 618097d 
> 
> Diff: https://git.reviewboard.kde.org/r/125206/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sayan Biswas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150912/8a401aa1/attachment.html>