Review Request 125206: Port of KIO::NetAccess

Aleix Pol Gonzalez aleixpol at kde.org
Sat Sep 12 20:33:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125206/#review85283
-----------------------------------------------------------



src/editor.cpp (line 175)
<https://git.reviewboard.kde.org/r/125206/#comment58944>

    This should be the QTemporaryFile



src/editor.cpp (line 191)
<https://git.reviewboard.kde.org/r/125206/#comment58945>

    This is just calling QFile::remove



src/editor.cpp (line 255)
<https://git.reviewboard.kde.org/r/125206/#comment58946>

    Remove commented code.


- Aleix Pol Gonzalez


On Sept. 12, 2015, 10:28 p.m., Sayan Biswas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125206/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 10:28 p.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: kturtle
> 
> 
> Description
> -------
> 
> Port of KIO::NetAccess
> 
> 
> Diffs
> -----
> 
>   src/editor.cpp 618097d 
> 
> Diff: https://git.reviewboard.kde.org/r/125206/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sayan Biswas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150912/3849eea8/attachment-0001.html>


More information about the kde-edu mailing list