Review Request 125147: Call parent ::event()

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125147/#review85143
-----------------------------------------------------------

Ship it!


Ship It!

- Andreas Cord-Landwehr


On Sept. 10, 2015, 9:05 nachm., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125147/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 9:05 nachm.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Repository: rocs
> 
> 
> Description
> -------
> 
> ::event() implementations need to call the parent ::event() otherwise things like deleteLater which is implemented in QObject::event won't work
> 
> In this case it probably doesn't matter, but it's always good to have "good code"
> 
> 
> Diffs
> -----
> 
>   libgraphtheory/kernel/edgewrapper.cpp 3593d8a 
>   libgraphtheory/kernel/nodewrapper.cpp c56625f 
> 
> Diff: https://git.reviewboard.kde.org/r/125147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150910/b10e0f37/attachment.html>