Review Request 125147: Call parent ::event()

Albert Astals Cid aacid at kde.org
Thu Sep 10 21:05:36 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125147/
-----------------------------------------------------------

Review request for KDE Edu and Andreas Cord-Landwehr.


Repository: rocs


Description
-------

::event() implementations need to call the parent ::event() otherwise things like deleteLater which is implemented in QObject::event won't work

In this case it probably doesn't matter, but it's always good to have "good code"


Diffs
-----

  libgraphtheory/kernel/edgewrapper.cpp 3593d8a 
  libgraphtheory/kernel/nodewrapper.cpp c56625f 

Diff: https://git.reviewboard.kde.org/r/125147/diff/


Testing
-------


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150910/3a08b1a8/attachment.html>


More information about the kde-edu mailing list