Review Request 125269: Remove eigen2 support completely

[Anton Gladky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125269/
-----------------------------------------------------------

(Updated Oct. 13, 2015, 8:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Andreas Cord-Landwehr.


Changes
-------

Submitted with commit d2c5d6a228a27875878f419c3c676d243d61c825 by Andreas Cord-Landwehr on behalf of Anton Gladky to branch master.


Repository: step


Description
-------

Remove eigen2 support completely


Diffs
-----

  CMakeLists.txt 6aacfa4 
  step/gasgraphics.cc 1c16d82 
  step/polygongraphics.cc 95cbfe8 
  step/toolgraphics.cc 70416b1 
  stepcore/constraintsolver.cc f68a66e 
  stepcore/coulombforce.cc 6a0e580 
  stepcore/eulersolver.cc f932c66 
  stepcore/gas.h cebde4a 
  stepcore/gas.cc 21a066d 
  stepcore/gravitation.cc c177337 
  stepcore/particle.cc 0eee19f 
  stepcore/rigidbody.cc b918a82 
  stepcore/spring.cc 974e1cc 
  stepcore/tool.h cff449e 

Diff: https://git.reviewboard.kde.org/r/125269/diff/


Testing
-------

This patch is applied in Debian [1] to remove eigen2-support completely, because new eigen3_3.3 (not released yet) will drop eigen2-constructions.

The only problem place, which needs to be good tested is the calculation of Vector2d forceV, which needed to be rewritten,
see short discussion here [2].

[1] http://anonscm.debian.org/cgit/pkg-kde/applications/step.git/commit/?id=82b74dd0026bdb1560efc317c2fa013be08b6c17
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786351#22


Thanks,

Anton Gladky

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20151013/39a63ad8/attachment.html>