Review Request 125269: Remove eigen2 support completely

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125269/#review86823
-----------------------------------------------------------

Ship it!


Many thanks for doing this port! I just pushed a unit test to verify the changed behavior in gravitation.cc and it looks good (actually the test fails currently due to the broken implementation with Eigen2). The commented code can now be removed and I marked one additional whitespace issue.

Do you have commit access or shall I push it for you?


stepcore/gas.cc (line 367)
<https://git.reviewboard.kde.org/r/125269/#comment59721>

    nitpick: please remove the whitespace, as you are already touching this line



stepcore/gravitation.cc (line 89)
<https://git.reviewboard.kde.org/r/125269/#comment59722>

    commented out code an be remove, please also remove the whitespace issues


- Andreas Cord-Landwehr


On Sept. 17, 2015, 5:11 vorm., Anton Gladky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125269/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 5:11 vorm.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Repository: step
> 
> 
> Description
> -------
> 
> Remove eigen2 support completely
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6aacfa4 
>   step/gasgraphics.cc 1c16d82 
>   step/polygongraphics.cc 95cbfe8 
>   step/toolgraphics.cc 70416b1 
>   stepcore/constraintsolver.cc f68a66e 
>   stepcore/coulombforce.cc 6a0e580 
>   stepcore/eulersolver.cc f932c66 
>   stepcore/gas.h cebde4a 
>   stepcore/gas.cc 21a066d 
>   stepcore/gravitation.cc c177337 
>   stepcore/particle.cc 0eee19f 
>   stepcore/rigidbody.cc b918a82 
>   stepcore/spring.cc 974e1cc 
>   stepcore/tool.h cff449e 
> 
> Diff: https://git.reviewboard.kde.org/r/125269/diff/
> 
> 
> Testing
> -------
> 
> This patch is applied in Debian [1] to remove eigen2-support completely, because new eigen3_3.3 (not released yet) will drop eigen2-constructions.
> 
> The only problem place, which needs to be good tested is the calculation of Vector2d forceV, which needed to be rewritten,
> see short discussion here [2].
> 
> [1] http://anonscm.debian.org/cgit/pkg-kde/applications/step.git/commit/?id=82b74dd0026bdb1560efc317c2fa013be08b6c17
> [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786351#22
> 
> 
> Thanks,
> 
> Anton Gladky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20151013/d31a75cd/attachment.html>