<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125269/">https://git.reviewboard.kde.org/r/125269/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Many thanks for doing this port! I just pushed a unit test to verify the changed behavior in gravitation.cc and it looks good (actually the test fails currently due to the broken implementation with Eigen2). The commented code can now be removed and I marked one additional whitespace issue.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do you have commit access or shall I push it for you?</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125269/diff/1/?file=404364#file404364line367" style="color: black; font-weight: bold; text-decoration: underline;">stepcore/gas.cc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Vector2d GasErrors::rectMeanVelocityVariance() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">367</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">velocityVariance</span> <span class="o">+=</span> <span class="p">(</span><span class="n">p1</span><span class="o">-></span><span class="n">velocity</span><span class="p">()</span> <span class="o">-</span> <span class="n">velocity</span><span class="p">).</span><span class="n"><span class="hl">cwise</span></span><span class="p">().</span><span class="n">square</span><span class="p">();</span><span class="ew"> </span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">367</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">velocityVariance</span> <span class="o">+=</span> <span class="p">(</span><span class="n">p1</span><span class="o">-></span><span class="n">velocity</span><span class="p">()</span> <span class="o">-</span> <span class="n">velocity</span><span class="p">).</span><span class="n"><span class="hl">array</span></span><span class="p">().</span><span class="n">square</span><span class="p">()<span class="hl">.</span></span><span class="n"><span class="hl">matrix</span></span><span class="p"><span class="hl">()</span>;</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">nitpick: please remove the whitespace, as you are already touching this line</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125269/diff/1/?file=404365#file404365line89" style="color: black; font-weight: bold; text-decoration: underline;">stepcore/gravitation.cc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void GravitationForce::calcForce(bool calcVariances)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commented out code an be remove, please also remove the whitespace issues</p></pre>
</div>
</div>
<br />
<p>- Andreas Cord-Landwehr</p>
<br />
<p>On September 17th, 2015, 5:11 vorm. UTC, Anton Gladky wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu and Andreas Cord-Landwehr.</div>
<div>By Anton Gladky.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2015, 5:11 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
step
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove eigen2 support completely</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is applied in Debian [1] to remove eigen2-support completely, because new eigen3_3.3 (not released yet) will drop eigen2-constructions.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only problem place, which needs to be good tested is the calculation of Vector2d forceV, which needed to be rewritten,
see short discussion here [2].</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] http://anonscm.debian.org/cgit/pkg-kde/applications/step.git/commit/?id=82b74dd0026bdb1560efc317c2fa013be08b6c17
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786351#22</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6aacfa4)</span></li>
<li>step/gasgraphics.cc <span style="color: grey">(1c16d82)</span></li>
<li>step/polygongraphics.cc <span style="color: grey">(95cbfe8)</span></li>
<li>step/toolgraphics.cc <span style="color: grey">(70416b1)</span></li>
<li>stepcore/constraintsolver.cc <span style="color: grey">(f68a66e)</span></li>
<li>stepcore/coulombforce.cc <span style="color: grey">(6a0e580)</span></li>
<li>stepcore/eulersolver.cc <span style="color: grey">(f932c66)</span></li>
<li>stepcore/gas.h <span style="color: grey">(cebde4a)</span></li>
<li>stepcore/gas.cc <span style="color: grey">(21a066d)</span></li>
<li>stepcore/gravitation.cc <span style="color: grey">(c177337)</span></li>
<li>stepcore/particle.cc <span style="color: grey">(0eee19f)</span></li>
<li>stepcore/rigidbody.cc <span style="color: grey">(b918a82)</span></li>
<li>stepcore/spring.cc <span style="color: grey">(974e1cc)</span></li>
<li>stepcore/tool.h <span style="color: grey">(cff449e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125269/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>