Review Request 125985: Fix build based on the changes for ECMQmLoader in ExtraCmakeModules

[Alex Merry]

> On Nov. 7, 2015, 2:02 p.m., Albert Astals Cid wrote:
> > This looks wrong, isn't this a mistake in ecm by doing a source incompatible change?
> 
> Alex Merry wrote:
>     Only in the sense that if you used the macro incorrectly before, it happened to work by fluke. Using the function from a different CMakeLists.txt file to the target it was being added to was never supposed to work. Neither was using a single call to the function for multiple targets (which I've seen in other projects). The function is patterned after things like the D-Bus interface generation macros, which will also not work if you try to use them like this. It just happened to work with the old implementation.

That said, I suppose e-c-m shouldn't even break that, especially given that several projects *have* used it in this way.

I'll revert the change for the version of e-c-m about to be released, and change the approach.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125985/#review88139
-----------------------------------------------------------


On Nov. 7, 2015, 1:22 p.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125985/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2015, 1:22 p.m.)
> 
> 
> Review request for KDE Edu and Alex Merry.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> Adjust the CMake files to build successfully after the changes to ECMQmLoader.  The fix is based on a similar fix from Alex, that he did for kconfig
> 
> 
> Diffs
> -----
> 
>   analitza/CMakeLists.txt 4894397 
>   CMakeLists.txt c79b00d 
> 
> Diff: https://git.reviewboard.kde.org/r/125985/diff/
> 
> 
> Testing
> -------
> 
> Build succesfully
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20151108/754950d2/attachment.html>