Review Request 125985: Fix build based on the changes for ECMQmLoader in ExtraCmakeModules

Alex Merry alex.merry at kde.org
Sun Nov 8 18:33:33 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125985/#review88164
-----------------------------------------------------------

Ship it!


Regardless of Albert's concerns about source compatibility in e-c-m, this change to analitza is sensible.

- Alex Merry


On Nov. 7, 2015, 1:22 p.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125985/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2015, 1:22 p.m.)
> 
> 
> Review request for KDE Edu and Alex Merry.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> Adjust the CMake files to build successfully after the changes to ECMQmLoader.  The fix is based on a similar fix from Alex, that he did for kconfig
> 
> 
> Diffs
> -----
> 
>   analitza/CMakeLists.txt 4894397 
>   CMakeLists.txt c79b00d 
> 
> Diff: https://git.reviewboard.kde.org/r/125985/diff/
> 
> 
> Testing
> -------
> 
> Build succesfully
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20151108/521b5413/attachment.html>


More information about the kde-edu mailing list