Review Request 125141: porting away from kdelibs44support

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125141/#review88036
-----------------------------------------------------------


Please always fill out the "testing" information, such that one know if you did any manual testing of the UI.
With regard to all KFileDialog -> QFileDialog changes it looks to me that the filters have to be changed (unlike the "old" KFilterDialog filters are still working but just are not documented in QFileDialog).
Could you test if the filter rules still work and if not make the changes as stated below?


src/editor.cpp (line 163)
<https://git.reviewboard.kde.org/r/125141/#comment60411>

    looking at the QFileDialog documentation, I think the filter syntax for QFileDialog is different than in KFileDialog, e.g. this should be 
    QString("%1 (*.turtle);;%2 (*.*)").arg(i18n("Turtle code files")).arg(i18n("All files"));



src/mainwindow.cpp (line 1052)
<https://git.reviewboard.kde.org/r/125141/#comment60412>

    please also check filter



src/mainwindow.cpp (line 1068)
<https://git.reviewboard.kde.org/r/125141/#comment60413>

    please also check filter


- Andreas Cord-Landwehr


On Sept. 10, 2015, 9:59 p.m., Sayan Biswas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125141/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 9:59 p.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: kturtle
> 
> 
> Description
> -------
> 
> porting of kcmdlineargs, kapplication and kaboutdata
> 
> 
> Diffs
> -----
> 
>   src/editor.cpp afd35e1 
>   src/mainwindow.cpp f2970a9 
> 
> Diff: https://git.reviewboard.kde.org/r/125141/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sayan Biswas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20151105/55b8c2ba/attachment.html>