<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125141/">https://git.reviewboard.kde.org/r/125141/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please always fill out the "testing" information, such that one know if you did any manual testing of the UI.
With regard to all KFileDialog -> QFileDialog changes it looks to me that the filters have to be changed (unlike the "old" KFilterDialog filters are still working but just are not documented in QFileDialog).
Could you test if the filter rules still work and if not make the changes as stated below?</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125141/diff/3/?file=402605#file402605line163" style="color: black; font-weight: bold; text-decoration: underline;">src/editor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool Editor::newFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">162</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="n">QString</span><span class="p">(</span><span class="s">"*.turtle|%1</span><span class="se">\n</span><span class="s">*|%2"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Turtle code files"</span><span class="p">)).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"All files"</span><span class="p">))<span class="hl">,</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">163</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span><span class="p">(</span><span class="s">"*.turtle|%1</span><span class="se">\n</span><span class="s">*|%2"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Turtle code files"</span><span class="p">)).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"All files"</span><span class="p">))<span class="hl">;</span></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">looking at the QFileDialog documentation, I think the filter syntax for QFileDialog is different than in KFileDialog, e.g. this should be
QString("%1 (<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">.turtle);;%2 (</em>.*)").arg(i18n("Turtle code files")).arg(i18n("All files"));</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125141/diff/3/?file=402606#file402606line1052" style="color: black; font-weight: bold; text-decoration: underline;">src/mainwindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MainWindow::exportToPng()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1051</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">QString</span> <span class="n">path</span> <span class="o">=</span> <span class="n"><span class="hl">K</span>FileDialog</span><span class="o">::</span><span class="n">getSaveFileName</span><span class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span class="n">QString</span><span class="p">(</span><span class="s">"*.svg|%1</span><span class="se">\n</span><span class="s">*|%2"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Scalable Vector Graphics"</span><span class="p">)).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"All files"</span><span class="p">))<span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"Save as SVG"</span></span><span class="p"><span class="hl">)</span>);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1052</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">QString</span> <span class="n">path</span> <span class="o">=</span> <span class="n"><span class="hl">Q</span>FileDialog</span><span class="o">::</span><span class="n">getSaveFileName</span><span class="p">(</span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"Save as SVG"</span></span><span class="p"><span class="hl">),</span></span><span class="hl"> </span><span class="n">QString</span><span class="p">(),</span> <span class="n">QString</span><span class="p">(</span><span class="s">"*.svg|%1</span><span class="se">\n</span><span class="s">*|%2"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Scalable Vector Graphics"</span><span class="p">)).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"All files"</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">please also check filter</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125141/diff/3/?file=402606#file402606line1068" style="color: black; font-weight: bold; text-decoration: underline;">src/mainwindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MainWindow::exportToSvg()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1067</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">QString</span> <span class="n">path</span> <span class="o">=</span> <span class="n"><span class="hl">K</span>FileDialog</span><span class="o">::</span><span class="n">getSaveFileName</span><span class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span class="n">QString</span><span class="p">(</span><span class="s">"*.html|%1</span><span class="se">\n</span><span class="s">*|%2"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"HTML documents"</span><span class="p">)).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"All files"</span><span class="p">))<span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"Save code as HTML"</span></span><span class="p"><span class="hl">)</span>);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1068</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">QString</span> <span class="n">path</span> <span class="o">=</span> <span class="n"><span class="hl">Q</span>FileDialog</span><span class="o">::</span><span class="n">getSaveFileName</span><span class="p">(</span><span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"Save code as HTML"</span></span><span class="p"><span class="hl">),</span></span><span class="hl"> </span><span class="n">QString</span><span class="p">(),</span> <span class="n">QString</span><span class="p">(</span><span class="s">"*.html|%1</span><span class="se">\n</span><span class="s">*|%2"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"HTML documents"</span><span class="p">)).</span><span class="n">arg</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"All files"</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">please also check filter</p></pre>
</div>
</div>
<br />
<p>- Andreas Cord-Landwehr</p>
<br />
<p>On September 10th, 2015, 9:59 p.m. UTC, Sayan Biswas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu and Jeremy Whiting.</div>
<div>By Sayan Biswas.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2015, 9:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kturtle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">porting of kcmdlineargs, kapplication and kaboutdata</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/editor.cpp <span style="color: grey">(afd35e1)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(f2970a9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125141/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>