Review Request 123823: [Cantor] KIntSpinBox ported to QSpinBox

Filipe Saraiva filipe at kde.org
Mon May 18 00:32:58 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123823/
-----------------------------------------------------------

(Updated May 18, 2015, 12:32 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.


Changes
-------

Submitted with commit e29deca5ff248b367e1bb60bbe5f17d31c90e88a by Filipe Saraiva to branch master.


Repository: cantor


Description
-------

KIntSpinBox is deprecated for KF5. The library was ported to QSpinBox.


Diffs
-----

  src/assistants/differentiate/differentiatedlg.ui 1966691 
  src/assistants/linearalgebra/creatematrix/creatematrixdlg.cpp 2d7fb2b 
  src/assistants/linearalgebra/creatematrix/creatematrixdlg.ui 6d354ea 
  src/backends/qalculate/settings.ui 7911ba7 

Diff: https://git.reviewboard.kde.org/r/123823/diff/


Testing
-------

* Build is ok.
* Library is utilized in Qalculate settings. Looks like correct.
* Library is utilized in matrix creation assistant. I created a matrix with Python 2 and looks lik ok.


Thanks,

Filipe Saraiva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150518/56d70af5/attachment.html>


More information about the kde-edu mailing list