Review Request 123823: [Cantor] KIntSpinBox ported to QSpinBox

Aleix Pol Gonzalez aleixpol at kde.org
Sun May 17 22:47:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123823/#review80547
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On May 17, 2015, 12:25 a.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123823/
> -----------------------------------------------------------
> 
> (Updated May 17, 2015, 12:25 a.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> KIntSpinBox is deprecated for KF5. The library was ported to QSpinBox.
> 
> 
> Diffs
> -----
> 
>   src/assistants/differentiate/differentiatedlg.ui 1966691 
>   src/assistants/linearalgebra/creatematrix/creatematrixdlg.cpp 2d7fb2b 
>   src/assistants/linearalgebra/creatematrix/creatematrixdlg.ui 6d354ea 
>   src/backends/qalculate/settings.ui 7911ba7 
> 
> Diff: https://git.reviewboard.kde.org/r/123823/diff/
> 
> 
> Testing
> -------
> 
> * Build is ok.
> * Library is utilized in Qalculate settings. Looks like correct.
> * Library is utilized in matrix creation assistant. I created a matrix with Python 2 and looks lik ok.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150517/e9fc6f32/attachment.html>


More information about the kde-edu mailing list