Review Request 123968: Simplify Finding GSL in CMake

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123968/#review81442
-----------------------------------------------------------


Sorry, for some reason I didn't receive of inadvertently deleted the notification for this RR.

OTOH I am currently not able to test patches like this on my own OSX/CI system, as it is in limbo since the transition to Scarlett's new KDE/CI system.

Will see whether I can test it anyway later. Please stay patient, I have it on my agenda now.

- Marko Käning


On June 7, 2015, 7:10 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123968/
> -----------------------------------------------------------
> 
> (Updated June 7, 2015, 7:10 a.m.)
> 
> 
> Review request for KDE Edu and Marko Käning.
> 
> 
> Repository: labplot
> 
> 
> Description
> -------
> 
> Use the module provided by CMake. Setting compile definitions HAVE_GSL and GSL_VERSION has no effect in the code so I removed them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt aff47951115403da86c8bfcfc2985da974aa7c0b 
> 
> Diff: https://git.reviewboard.kde.org/r/123968/diff/
> 
> 
> Testing
> -------
> 
> Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this still works in the OSX configuration, Marko?
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150613/4c943ebc/attachment.html>