Review Request 123968: Simplify Finding GSL in CMake

David Narváez david.narvaez at computer.org
Sun Jun 7 05:10:11 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123968/
-----------------------------------------------------------

(Updated June 7, 2015, 5:10 a.m.)


Review request for KDE Edu and Marko Käning.


Repository: labplot


Description (updated)
-------

Use the module provided by CMake. Setting compile definitions HAVE_GSL and GSL_VERSION has no effect in the code so I removed them.


Diffs (updated)
-----

  CMakeLists.txt aff47951115403da86c8bfcfc2985da974aa7c0b 

Diff: https://git.reviewboard.kde.org/r/123968/diff/


Testing
-------

Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this still works in the OSX configuration, Marko?


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150607/908acdb6/attachment.html>


More information about the kde-edu mailing list