Review Request 124040: Fix "close" button in tabbar after porting from KTabWidget to QTabWidget

Alexander Potashev aspotashev at gmail.com
Wed Jun 10 10:17:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124040/
-----------------------------------------------------------

(Updated Июнь 10, 2015, 10:17 д.п.)


Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, Lucas Hermann Negri, and Minh Ngo.


Changes
-------

update commit message


Summary (updated)
-----------------

Fix "close" button in tabbar after porting from KTabWidget to QTabWidget


Repository: cantor


Description (updated)
-------

Use signal QTabWidget::tabCloseRequested(int) instead of
KTabWidget::closeRequest(QWidget*).

Problem introduced by commit 8711f0596f03658de1627a2862c1893cb766e8bc
"Port KTabWidget to QTabWidget", review request 123966.


Diffs (updated)
-----

  src/cantor.h 2c12b3d0b0ceec35967eee1efb7afa372282c6d2 
  src/cantor.cpp 02c6cf3d8fcc73f2d8fe86819a56269682effe21 

Diff: https://git.reviewboard.kde.org/r/124040/diff/


Testing
-------

Closing tabs works by clicking on the "x" button in the tabbar and by clicking "File -> Close".


Thanks,

Alexander Potashev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150610/6df6037f/attachment.html>


More information about the kde-edu mailing list