Review Request 124040: CantorShell: Port away from KTabWidget's signal closeRequest(QWidget*)

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124040/#review81312
-----------------------------------------------------------


You are not saying why you did the change...

- Aleix Pol Gonzalez


On June 8, 2015, 1:13 p.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124040/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 1:13 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, Lucas Hermann Negri, and Minh Ngo.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Use signal QTabWidget::tabCloseRequested(int) instead.
> 
> 
> Diffs
> -----
> 
>   src/cantor.h 2c12b3d0b0ceec35967eee1efb7afa372282c6d2 
>   src/cantor.cpp 02c6cf3d8fcc73f2d8fe86819a56269682effe21 
> 
> Diff: https://git.reviewboard.kde.org/r/124040/diff/
> 
> 
> Testing
> -------
> 
> Closing tabs works by clicking on the "x" button in the tabbar and by clicking "File -> Close".
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150608/46bfd270/attachment.html>