Review Request 124010: [Cantor] Port KFileDialog to QFileDialog

Filipe Saraiva filipe at kde.org
Fri Jun 5 17:20:13 UTC 2015



> On Junho 5, 2015, 12:05 a.m., Aleix Pol Gonzalez wrote:
> > src/scripteditorwidget.cpp, line 97
> > <https://git.reviewboard.kde.org/r/124010/diff/1/?file=378839#file378839line97>
> >
> >     There's getOpenFileUrl, much better in this case.

Changed to:

 QUrl url = QFileDialog::getOpenFileUrl(this, QString(), QUrl(), m_filter);


> On Junho 5, 2015, 12:05 a.m., Aleix Pol Gonzalez wrote:
> > src/scripteditorwidget.cpp, line 98
> > <https://git.reviewboard.kde.org/r/124010/diff/1/?file=378839#file378839line98>
> >
> >     I'm unsure how the kfiledialog:// will work, tbh...

Dropped by previous fix.


- Filipe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124010/#review81219
-----------------------------------------------------------


On Junho 4, 2015, 10:05 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124010/
> -----------------------------------------------------------
> 
> (Updated Junho 4, 2015, 10:05 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> KFileDialog is deprecated for KF5. The library was ported to QFileDialog. Some changes in QFileDialog filters were performed in *extensions.cpp files.
> 
> 
> Diffs
> -----
> 
>   src/assistants/runscript/runscriptassistant.cpp fb07f15 
>   src/backends/R/rextensions.cpp c4e6cba 
>   src/backends/lua/luaextensions.cpp bf522bb 
>   src/backends/maxima/maximaextensions.cpp c36cc75 
>   src/backends/octave/octaveextensions.cpp 55e3eca 
>   src/backends/python/pythonextensions.cpp f13d662 
>   src/backends/sage/sageextensions.cpp 022630c 
>   src/backends/scilab/scilabextensions.cpp bd04edf 
>   src/scripteditorwidget.cpp ff3530e 
> 
> Diff: https://git.reviewboard.kde.org/r/124010/diff/
> 
> 
> Testing
> -------
> 
> * Build ok;
> * The filters are working properly.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150605/0b8a87da/attachment.html>


More information about the kde-edu mailing list