Review Request 124010: [Cantor] Port KFileDialog to QFileDialog

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124010/#review81219
-----------------------------------------------------------



src/scripteditorwidget.cpp (line 97)
<https://git.reviewboard.kde.org/r/124010/#comment55617>

    There's getOpenFileUrl, much better in this case.



src/scripteditorwidget.cpp (line 98)
<https://git.reviewboard.kde.org/r/124010/#comment55618>

    I'm unsure how the kfiledialog:// will work, tbh...


- Aleix Pol Gonzalez


On June 5, 2015, 12:05 a.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124010/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 12:05 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> KFileDialog is deprecated for KF5. The library was ported to QFileDialog. Some changes in QFileDialog filters were performed in *extensions.cpp files.
> 
> 
> Diffs
> -----
> 
>   src/assistants/runscript/runscriptassistant.cpp fb07f15 
>   src/backends/R/rextensions.cpp c4e6cba 
>   src/backends/lua/luaextensions.cpp bf522bb 
>   src/backends/maxima/maximaextensions.cpp c36cc75 
>   src/backends/octave/octaveextensions.cpp 55e3eca 
>   src/backends/python/pythonextensions.cpp f13d662 
>   src/backends/sage/sageextensions.cpp 022630c 
>   src/backends/scilab/scilabextensions.cpp bd04edf 
>   src/scripteditorwidget.cpp ff3530e 
> 
> Diff: https://git.reviewboard.kde.org/r/124010/diff/
> 
> 
> Testing
> -------
> 
> * Build ok;
> * The filters are working properly.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150605/57200eaa/attachment.html>