Review Request 124008: Port KDialog to QDialog + QDialogButtonBox

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124008/#review81202
-----------------------------------------------------------


LGTM. +1

- Aleix Pol Gonzalez


On June 4, 2015, 8:53 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124008/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 8:53 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> KDialog is deprecated for KF5. We port it to QDialog + QDialogButtonBox using convert-kdialog script and some manual work.
> 
> 
> Diffs
> -----
> 
>   src/assistants/advancedplot/advancedplotassistant.cpp 4d5972f 
>   src/assistants/advancedplot/advancedplotdialog.ui 5a21791 
>   src/assistants/differentiate/differentiateassistant.cpp a4e9b56 
>   src/assistants/differentiate/differentiatedlg.ui b603374 
>   src/assistants/importpackage/importpackageassistant.cpp 716eeed 
>   src/assistants/importpackage/importpackagedlg.ui dd19fe8 
>   src/assistants/integrate/integrateassistant.cpp 4c65f73 
>   src/assistants/integrate/integratedlg.ui d28096d 
>   src/assistants/linearalgebra/eigenvalues/eigenvaluesassistant.cpp 95c84f8 
>   src/assistants/linearalgebra/eigenvalues/eigenvaluesdlg.ui 2d61448 
>   src/assistants/linearalgebra/eigenvectors/eigenvectorsassistant.cpp c2f8319 
>   src/assistants/linearalgebra/eigenvectors/eigenvectorsdlg.ui 3eeb2ef 
>   src/assistants/linearalgebra/invertmatrix/invertmatrixassistant.cpp 0cd2a74 
>   src/assistants/linearalgebra/invertmatrix/invertmatrixdlg.ui c53df25 
>   src/assistants/plot2d/plot2dassistant.cpp 0e05cc3 
>   src/assistants/plot2d/plot2ddlg.ui a8ee36b 
>   src/assistants/plot3d/plot3dassistant.cpp 688d2f1 
>   src/assistants/plot3d/plot3ddlg.ui ce1b1fa 
>   src/assistants/solve/solveassistant.cpp 015c1a1 
>   src/assistants/solve/solvedlg.ui ad4cc10 
>   src/backends/qalculate/plotassistant/qalculateplotassistant.h a87769a 
>   src/backends/qalculate/plotassistant/qalculateplotassistant.cpp 26fe144 
>   src/backends/qalculate/plotassistant/qalculateplotdialog.ui 5820335 
>   src/cantor.cpp 9577061 
>   src/panelplugins/variablemgr/newvardlg.ui 0a767be 
>   src/panelplugins/variablemgr/variablemanagerwidget.cpp 8729ffc 
> 
> Diff: https://git.reviewboard.kde.org/r/124008/diff/
> 
> 
> Testing
> -------
> 
> * Build ok;
> * We tested the buttons for each change in the dialogs.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150604/d046f67f/attachment.html>