<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124008/">https://git.reviewboard.kde.org/r/124008/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">LGTM. +1</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On June 4th, 2015, 8:53 p.m. CEST, Filipe Saraiva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Aleix Pol Gonzalez and Alexander Rieder.</div>
<div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated June 4, 2015, 8:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDialog is deprecated for KF5. We port it to QDialog + QDialogButtonBox using convert-kdialog script and some manual work.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Build ok;</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">We tested the buttons for each change in the dialogs.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/assistants/advancedplot/advancedplotassistant.cpp <span style="color: grey">(4d5972f)</span></li>
<li>src/assistants/advancedplot/advancedplotdialog.ui <span style="color: grey">(5a21791)</span></li>
<li>src/assistants/differentiate/differentiateassistant.cpp <span style="color: grey">(a4e9b56)</span></li>
<li>src/assistants/differentiate/differentiatedlg.ui <span style="color: grey">(b603374)</span></li>
<li>src/assistants/importpackage/importpackageassistant.cpp <span style="color: grey">(716eeed)</span></li>
<li>src/assistants/importpackage/importpackagedlg.ui <span style="color: grey">(dd19fe8)</span></li>
<li>src/assistants/integrate/integrateassistant.cpp <span style="color: grey">(4c65f73)</span></li>
<li>src/assistants/integrate/integratedlg.ui <span style="color: grey">(d28096d)</span></li>
<li>src/assistants/linearalgebra/eigenvalues/eigenvaluesassistant.cpp <span style="color: grey">(95c84f8)</span></li>
<li>src/assistants/linearalgebra/eigenvalues/eigenvaluesdlg.ui <span style="color: grey">(2d61448)</span></li>
<li>src/assistants/linearalgebra/eigenvectors/eigenvectorsassistant.cpp <span style="color: grey">(c2f8319)</span></li>
<li>src/assistants/linearalgebra/eigenvectors/eigenvectorsdlg.ui <span style="color: grey">(3eeb2ef)</span></li>
<li>src/assistants/linearalgebra/invertmatrix/invertmatrixassistant.cpp <span style="color: grey">(0cd2a74)</span></li>
<li>src/assistants/linearalgebra/invertmatrix/invertmatrixdlg.ui <span style="color: grey">(c53df25)</span></li>
<li>src/assistants/plot2d/plot2dassistant.cpp <span style="color: grey">(0e05cc3)</span></li>
<li>src/assistants/plot2d/plot2ddlg.ui <span style="color: grey">(a8ee36b)</span></li>
<li>src/assistants/plot3d/plot3dassistant.cpp <span style="color: grey">(688d2f1)</span></li>
<li>src/assistants/plot3d/plot3ddlg.ui <span style="color: grey">(ce1b1fa)</span></li>
<li>src/assistants/solve/solveassistant.cpp <span style="color: grey">(015c1a1)</span></li>
<li>src/assistants/solve/solvedlg.ui <span style="color: grey">(ad4cc10)</span></li>
<li>src/backends/qalculate/plotassistant/qalculateplotassistant.h <span style="color: grey">(a87769a)</span></li>
<li>src/backends/qalculate/plotassistant/qalculateplotassistant.cpp <span style="color: grey">(26fe144)</span></li>
<li>src/backends/qalculate/plotassistant/qalculateplotdialog.ui <span style="color: grey">(5820335)</span></li>
<li>src/cantor.cpp <span style="color: grey">(9577061)</span></li>
<li>src/panelplugins/variablemgr/newvardlg.ui <span style="color: grey">(0a767be)</span></li>
<li>src/panelplugins/variablemgr/variablemanagerwidget.cpp <span style="color: grey">(8729ffc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124008/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>