Review Request 123982: Cleanup CMakeLists and drop KDELibs4Support

[Laurent Navet]

On June 1, 2015, 10:34 p.m., Laurent Navet wrote:
> > Looks good, but probably want to use ecm_add_app_icon rather than nothing.

I think it's already done :
http://quickgit.kde.org/?p=klettres.git&a=blob&h=eb6adc92dc11d5d54860be01b44242a2fbcb31f0&f=src%2FCMakeLists.txt&o=plain

Here is the commit :
http://quickgit.kde.org/?p=klettres.git&a=commit&h=fde370b8ca6cf803e3765faee585d6401db9b224


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123982/#review81062
-----------------------------------------------------------


On June 1, 2015, 10:27 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123982/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 10:27 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: klettres
> 
> 
> Description
> -------
> 
> Cleanup CMakeLists and drop KDELibs4Support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b280cf2 
>   src/CMakeLists.txt eb6adc9 
> 
> Diff: https://git.reviewboard.kde.org/r/123982/diff/
> 
> 
> Testing
> -------
> 
> make && make test
> and run
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150601/f2c36fcc/attachment.html>