Review Request 123982: Cleanup CMakeLists and drop KDELibs4Support

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123982/#review81062
-----------------------------------------------------------



src/CMakeLists.txt 
<https://git.reviewboard.kde.org/r/123982/#comment55501>

    I wouldn't remove these lines though they are commented out until you replace them with ecm_add_app_icon. I believe that's been in at least one ecm release by now, so go ahead and use it.


Looks good, but probably want to use ecm_add_app_icon rather than nothing.

- Jeremy Whiting


On June 1, 2015, 2:27 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123982/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 2:27 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: klettres
> 
> 
> Description
> -------
> 
> Cleanup CMakeLists and drop KDELibs4Support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b280cf2 
>   src/CMakeLists.txt eb6adc9 
> 
> Diff: https://git.reviewboard.kde.org/r/123982/diff/
> 
> 
> Testing
> -------
> 
> make && make test
> and run
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150601/22f4c416/attachment.html>