Review Request 122568: option to ignore punctuation

[Inge Wallin]

> On Feb. 15, 2015, 5:52 a.m., Inge Wallin wrote:
> > Hi Ankit,
> > I can't check the current state of the patch since you ony added the changes from version 1. What I saw looked good, but I can't give you a Ship it just yet.  But you are close.
> > 
> > Today I will go on a trip to Poland so I suggest that you ask jpwhiting to help you with the review.  He can show you what to do and knows enough to give you the Ok.

Hello, what happened? It would be very good if you could post the complete patch since the feature freeze for the next version is on wednesday and I would like to get this in before then.  I think you did a good job, I just want to take a look at the complete work once before ok
'ing it.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122568/#review76039
-----------------------------------------------------------


On Feb. 15, 2015, 5:11 a.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122568/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2015, 5:11 a.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> An option to ignore punctuation has been added.
> 
> 
> Diffs
> -----
> 
>   0001-option-to-ignore-punctation-has-been-added.patch PRE-CREATION 
>   src/collection/testentry.h 4f47c38 
>   src/practice/writtenpracticevalidator.cpp e974441 
> 
> Diff: https://git.reviewboard.kde.org/r/122568/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> ankit wagadre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150221/fac354fb/attachment.html>