Review Request 122568: option to ignore punctuation

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122568/#review76039
-----------------------------------------------------------


Hi Ankit,
I can't check the current state of the patch since you ony added the changes from version 1. What I saw looked good, but I can't give you a Ship it just yet.  But you are close.

Today I will go on a trip to Poland so I suggest that you ask jpwhiting to help you with the review.  He can show you what to do and knows enough to give you the Ok.


0001-option-to-ignore-punctation-has-been-added.patch
<https://git.reviewboard.kde.org/r/122568/#comment52474>

    The patch file itself should definitely not be part of the patch.  How did you generate this diff? The right way is using "git diff > Patchfile.diff" If you do that they you will only get those files that are changed.


- Inge Wallin


On Feb. 15, 2015, 5:11 a.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122568/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2015, 5:11 a.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> An option to ignore punctuation has been added.
> 
> 
> Diffs
> -----
> 
>   0001-option-to-ignore-punctation-has-been-added.patch PRE-CREATION 
>   src/collection/testentry.h 4f47c38 
>   src/practice/writtenpracticevalidator.cpp e974441 
> 
> Diff: https://git.reviewboard.kde.org/r/122568/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> ankit wagadre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150215/d179d3ed/attachment.html>