Review Request 122568: option to ignore punctuation

[ankit wagadre]

> On Feb. 14, 2015, 1:39 p.m., Inge Wallin wrote:
> > config-parley.h.cmake.user, line 1
> > <https://git.reviewboard.kde.org/r/122568/diff/1/?file=349299#file349299line1>
> >
> >     What is this file used for? Is it autogenerated by Qt Creator? I am not sure it should be part of the patch.

yes,its autogenerated.


> On Feb. 14, 2015, 1:39 p.m., Inge Wallin wrote:
> > src/practice/writtenpracticevalidator.cpp, line 172
> > <https://git.reviewboard.kde.org/r/122568/diff/1/?file=349304#file349304line172>
> >
> >     Hmm, why would isCapitalizationMistake() check the setting for punctuation mistakes?

This one is necessary as if both option are checked(ignore capitalization and punctuation) then there should be one option to check both.


> On Feb. 14, 2015, 1:39 p.m., Inge Wallin wrote:
> > src/practice/writtenpracticevalidator.cpp, line 159
> > <https://git.reviewboard.kde.org/r/122568/diff/1/?file=349304#file349304line159>
> >
> >     I don't understand this addition to the comment, really.

sory that was by mistake.


- ankit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122568/#review76026
-----------------------------------------------------------


On Feb. 14, 2015, 1:19 p.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122568/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2015, 1:19 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> An option to ignore punctuation has been added.
> 
> 
> Diffs
> -----
> 
>   src/practice/writtenpracticevalidator.cpp e974441 
>   src/settings/parley.kcfg 0037420 
>   src/practice/writtenpracticevalidator.h 93e7423 
>   config-parley.h.cmake.user PRE-CREATION 
>   src/collection/testentry.h 4f47c38 
>   src/practice/configure/generalpracticeoptions.ui a40c739 
>   src/practice/writtenbackendmode.cpp 7b221b7 
> 
> Diff: https://git.reviewboard.kde.org/r/122568/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> ankit wagadre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150215/7ab01047/attachment-0001.html>