Review Request 122568: option to ignore punctuation

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122568/#review76026
-----------------------------------------------------------


This is a very good start.  There were a few mistakes that need to be fixed (most important one is the enum value) but I don't think we will need more than one more pass through review before we can say that this is done.

Good job!


config-parley.h.cmake.user
<https://git.reviewboard.kde.org/r/122568/#comment52460>

    What is this file used for? Is it autogenerated by Qt Creator? I am not sure it should be part of the patch.



src/collection/testentry.h
<https://git.reviewboard.kde.org/r/122568/#comment52461>

    Notice that the other enum values all have a single bit set. You have to give PunctuationMistake the value 0x08, move ArticleWrong to 0x10, ArticleMissing 0x20, and so on. The current value indicates that PunctuationMistake is a combination of CapitalizationMistake and AccentMistake, which is of course not true.



src/practice/writtenpracticevalidator.cpp
<https://git.reviewboard.kde.org/r/122568/#comment52464>

    I don't understand this addition to the comment, really.



src/practice/writtenpracticevalidator.cpp
<https://git.reviewboard.kde.org/r/122568/#comment52465>

    Hmm, why would isCapitalizationMistake() check the setting for punctuation mistakes?


- Inge Wallin


On Feb. 14, 2015, 2:19 p.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122568/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2015, 2:19 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> An option to ignore punctuation has been added.
> 
> 
> Diffs
> -----
> 
>   src/practice/writtenpracticevalidator.cpp e974441 
>   src/settings/parley.kcfg 0037420 
>   src/practice/writtenpracticevalidator.h 93e7423 
>   config-parley.h.cmake.user PRE-CREATION 
>   src/collection/testentry.h 4f47c38 
>   src/practice/configure/generalpracticeoptions.ui a40c739 
>   src/practice/writtenbackendmode.cpp 7b221b7 
> 
> Diff: https://git.reviewboard.kde.org/r/122568/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> ankit wagadre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150214/8f80471a/attachment.html>