Review Request 122458: Fix variables persistence in backends to Python 2 and 3

Filipe Saraiva filipe at kde.org
Fri Feb 6 16:51:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122458/#review75538
-----------------------------------------------------------



src/backends/python/variables_saver.py
<https://git.reviewboard.kde.org/r/122458/#comment52243>

    Well, it is just a condition analysys(__if__)... there is not problem here, right?


- Filipe Saraiva


On Fev. 6, 2015, 4:46 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122458/
> -----------------------------------------------------------
> 
> (Updated Fev. 6, 2015, 4:46 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Fix the script to save variables of Python 2 and Python 3 environment correctly. Previous version of the function did not work in Python 3 (because there is not _unicode_ function in Python 3).
> 
> I would like to request the review because I don't have idea about the impact of change _unicode_ function to _str_ function in Python 2.
> 
> 
> Diffs
> -----
> 
>   src/backends/python/variables_saver.py e90c496 
> 
> Diff: https://git.reviewboard.kde.org/r/122458/diff/
> 
> 
> Testing
> -------
> 
> In both Pythn 2 and Python 3 backends:
> 
> * Save different types of variables (float, int, string, numpy.array) to a file;
> * Load this file to Cantor.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150206/e3f05bc0/attachment.html>


More information about the kde-edu mailing list